1
0
-1

Hi,

I'm using Mercurial (hosted at BitBucket) and currently evaluating Crucible as a code review tool for my team. We have one fairly critical repository where we would like to setup reviews for each changeset pushed to that repository (optionally excluding some individual commits by some special string inside commit message). Is this kind of workflow possible in Crucible?

    CommentAdd your comment...

    5 answers

    1.  
      3
      2
      1

      There is the Automatic Review Creator but unfortunately it's incompatible with recent Crucible versions.

        CommentAdd your comment...
      1.  
        3
        2
        1

        In my opinion (of course, there are always exceptions), creating a review for each revision might be a bit excessive in many cases.

        I would say that is much more realistic using a repository browser deeply integrated with JIRA. In that way, users might view when code has been reviewed or not while them explore changes: log/history command, revision graphs, open a file, and so on.

        In addition, users should be able to ask for review from JIRA if they want to be sure that code is ok. Simply: click on a revision and ask for review.

        That integrated repository browser should also be able to filter changes by user allowing to review changes made by a recently hired employee, by example.

        If you are using Subversion then there is available a plugin providing all features described above and much more.

          CommentAdd your comment...
        1.  
          1
          0
          -1

          I was actually been able to install that plugin into Crucible 2.6.0 and it seems to work quite nicely, but it doesn't quite support Iterative Reviews. Even if I enable the "Enable iterative reviews" checkbox in settings in the Administration section, it still creates new reviews automatically for those changesets which contain only changes which are part of files under existing reviews.

          It would be nice if the code author who receives review feedback could commit fixes with some special commit message prefix (e.g. the code review ID) so that Crucible would know that this specific commit is associated with this specific, existing review, and that no new reviews should be created automatically. Is there such a feature?

            CommentAdd your comment...
          1.  
            1
            0
            -1

            You can use mercurial post commit hook and create a script using the Crucible API:

            http://confluence.atlassian.com/display/FECRUDEV/REST+API+Guide

            to create a review after each commit.

              CommentAdd your comment...
            1.  
              1
              0
              -1

              I've got a great solution if you're arriving at this thread looking for a script to automate review creation (or just some Python to illustrate how to use the REST API) ... introducing Mullite!

              https://github.com/60East/mullite

              Clone it, write your config file, cron it and you're set!

                CommentAdd your comment...