Stash review complete button/flag

[Joel Pearson]

Is there some way in Stash to say that I've completed reviewing the code?

There is the approve button, but that is only useful if you're happy with the code.

However, if you want to let the developer know that you've finished reviewing and that they can start implementing your changes, there is no way to do this, other than leaving a comment saying "Finished reviewing". 

Otherwise, the developer will end up pushing up lots of tiny commits for each comment, when it's usually nicer to bundle the changes once the reviewer has finished.

[Balázs Szakmáry · Accepted solution]

Leaving a "Finished reviewing" comment as you suggest is the best option you have. On the other hand, this would be a very simple plugin if you want to implement it.

[Joel Pearson]

Do you happen to know which part of the SDK allows hooks into the Pull request UI?

[Joel Pearson]

I found 2 plugins that have source code available that could easily be used as the basis of a review complete plugin: https://marketplace.atlassian.com/plugins/com.atlassian.stash.plugin.stash-auto-unapprove-plugin#support https://marketplace.atlassian.com/plugins/com.palantir.stash.stash-disapprove-plugin Auto-unapprove button concept could be used to clear the "review complete" on new pull requests. And the disapprove-plugin to see how to add buttons to a pull request.

[Marcin]

There isn't currently a feature like this, however there is an existing open feature suggestion to track this idea: https://jira.atlassian.com/browse/STASH-2999

You can add your vote, as votes are one factor we use when determining features to roadmap, and keep watch on that issue for any future updates.

Cheers,

Marcin
Stash Developer

[Ken Hill]

My company couldn't wait any longer. I created this plugin to enable this workflow: https://marketplace.atlassian.com/plugins/steeltomato.review-complete-plugin/server/overview