Setting to pre-fetch the next file differences?

[Kyle Ford]

Sometimes, I review a lot of small file changes on Crucible.  When that happens, I click on a file, confirm the change in 2 seconds, then select the next file, wait for 2-3 seconds "Loading diff...", the display refreshes, and I confirm the changes.  I click on the next file, and wait for 2-3 seconds "Loading diff...".

What would be great, is if those differences were fetched in the background.  Review file #1, show and fetch differences for file #2 in the background before the file is clicked, then when I review file #2, I don't have to wait.  That could effectively double my code review speed for these types of scenarios.

Is there a setting somewhere to enable this behavior?

[Kyle Ford]

I'm still slowly going through the code review, and it is up to 143 requests at 1.5 MB transferred.  It seems that you are suggesting that all of these requests should have been completed in the background.  I am seeing additional requests as I load each "file difference".

I occasionally get a 404, page not found.  Sometimes it is a missing icon, or a name associated with another code reviewer.  However, I don't get 404 errors for every "file difference" and it still takes about a minute to load some pages.

[Kyle Ford]

Not sure what I am looking at, but the session show is 33 minutes, and the highlighted call is taking 9 seconds to load a page diff for one of the files I am reviewing.  So it doesn't seem to matter how long I am in review, there are still file differences to be fetched.  Is there some other data I can provide to help show what is going on?

image2015-4-13 15:31:17.png

[lpater]

Hi Kyle,

The actual implementation should already do that. When you open the review we build a queue of files/diffs to load. The clicked file lands at the top of that queue, and when that's loaded the next files should be loaded in the background (and then available immediately when you click on them, without an additional request to the server).

You should be able to see the requests for subsequent files in your browser as 'loadFrxAjax' requests:

frxs.png

You might want to check if these are being made, and successful.