Ability to view all statuses

Thys De Bruyn February 19, 2015
  • "Gerrit Reviews" issue tab panel to show all reviews related to the issue

 

Hi

Is it possible to view all statuses. In my current default setup, we only see a review if it's OPEN. Once it is merged, closed, abandoned etc then it moves out of the tab and doesn't display anymore

Kind regards

Thys

1 answer

0 votes
jhansche March 19, 2015

Which view are you using?

  • Gerrit Reviews Tab Panel - appears as a tab next to "History", "Comments", etc.
  • Gerrit Reviews Side Panel - appears as a panel on the right side, next to "People", "Dates", etc.
  • Gerrit Reviews Web Panel - appears as a panel in the main section of the issue, between "Sub Tasks" and "Activity"

The ability to toggle all-vs-open is only present in the "Web" panel, and you can see it in the top-right corner of the web panel, as a down-arrow drop-down list:

Screen Shot 2015-03-19 at 2.01.19 PM.png

To toggle which Gerrit panel view appears in the JIRA issues, go to the "Manage Add-Ons" system configuration screen, find the Gerrit plugin, and look for the "+" sign for "... of 28 modules enabled".  In that list, there are 4 "Panel" entries, each of which enable different views of the plugin (having them all enabled probably doesn't make sense, so choose the one that you prefer – or in the case of the "Tab Panel" you can enable both the reviews tab and the subtask reviews tab).  But to get the "All" vs "Open" option pictured above, you need the "Gerrit Reviews Web Panel" module enabled:

Screen Shot 2015-03-19 at 2.02.50 PM.png

To enable or disable one of these modules, rest over the cell to reveal a "Disable" or "Enable" button on the right side (where the screenshot above shows the red "Disabled" indicator).

jhansche March 19, 2015

However, all that said... If you are using the "message:%s" search predicate, and you *do not have* the Lucene index enabled, then Gerrit will by default only include the open reviews in that result. You should consider upgrading your Gerrit instance to a version that includes the Lucene index. That allows the "message:%s" predicate to work very fast, and can include both open and closed reviews.

Thys De Bruyn March 20, 2015

How would I go about upgrading to that version. I have the latest Gerrit plugin installed on the server. The module Enable/Disable still only uses the Issue Search condition that is applied. Even when only using "message:%s" it only displays OPEN reviews in the web tab

Thys De Bruyn March 20, 2015

On our Gerrit instance: Powered by Gerrit Code Review (2.8.3) , is that the version?

jhansche March 20, 2015

According to <https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.8.3.html>;, that version of Gerrit does include the lucene index. Did you change anything in the plugin's modules? What module are you using now? If you're using the "Gerrit Reviews Web Panel", then you should be able to change the dropdown option as noted in my screenshot above, to "Show All Reviews" (I've noticed an issue where sometimes it will show the "All" item selected, but it's actually only showing the "Open" reviews -- or vice versa. To test that theory, try changing the option and then change it back to "Show All Reviews"

jhansche March 20, 2015

The next thing to try is going to your gerrit web interface, and enter the same search predicate there. For example, if your JIRA Gerrit Plugin is configured to use "message:%s" and you're trying to look at a JIRA issue named "TEST-1234", then go to your gerrit server, log in, and in the top-right search bar, enter: "message:TEST-1234". The plugin *can only show what it gets back from a search query*, so if the closed reviews are not showing up there, that means that Gerrit cannot show them and no amount of configuring in JIRA will change that. If that is the case, then you might want to try upgrading gerrit: https://code.google.com/p/gerrit/

Thys De Bruyn March 22, 2015

Thanks Joe. The search in Gerrit as mentioned above, only returns open reviews. It doesn't show all statuses for a specific Jira issue. I've also tried updating Jira plugin to use message:%1$s or message:%s. If I do a status:merged search in gerrit then it shows me the closed reviews for my jira ticket, and if open search shows the open ones for that same ticket. But the message:xxxx only returns with status open. Is there a Gerrit configuration that needs to be done?

Thys De Bruyn March 22, 2015

And switching on the Web Panel only: Show All Reviews and vice versa, still only shows open reviews.

Thys De Bruyn March 22, 2015

Seeing like we may be moving back to Crucible Reviews. But have requested that they update Gerrit to the latest version. Seems like everyone wants the functionality to do search for multiple status for a single issue, but it is too much of a hassle to get this to work. Thanks for your help Joe.

Suggest an answer

Log in or Sign up to answer
TAGS
AUG Leaders

Atlassian Community Events