basic feature missing: full-source pre-commit code reviews with Perforce

[Christopher Corbell]

This is a feature request. My company is on JIRA and Confluence and would love to integrate Crucible, but this is a deal-breaker and until the feature is part of Crucible we will continue to use Reviewboard.

Use case: developer shares full-source code review before checking in code

Source control system: perforce

Expected success steps:

1. Developer has a perforce change list with local edits to a set of files.

2. Developer creates (through a simple script or action) a review of the changelist.

3. Developer publishes the review to the team.

4. The team is able to review diffs for all files in the pending changelist, including full source with the diffs (not just partial patch).

5. Team members ok the review.

6. Developer submits the changelist.

This use case is fully implemented by Reviewboard using their post-review command-line tool and perforce integration. There are other things we'd like from crucible but we won't sacrifice this most essential use case.

Also, a related use case would be to update an existing review when further changes are made to the same perforce changelist locally (but still not checked in) - e.g. correcting issues that reviewers found. Reviewboard also supports this, calling post-review on the same changelist will update the diffs to reflect the latest changes on the developer's local filesystem.

Thanks for considering this feature request, please do send a note if you ever implement and we will re-evaluate a purchase of crucible.

Best regards,

Chris Corbell

Extensis

[Curt Patrick]

That strikes me as a clunky, incomplete "solution".

My company created a skunkworks project (https://github.com/Netflix-Skunkworks/post2crucible.git) to emulate the steps described above. But now we have to maintain the tool. It seems to me that, since Atlassian is in the code review business, you guys could (and should) provide such a tool. Is there any hope of that happening?

[Foong]

It seems that you are looking for this feature request: https://jira.atlassian.com/browse/CRUC-3378

[Dhandapani subramani]

you can upload the files using curl for pre commit, either you can use the password or generate the token and parse the file for upload

system("curl --cookie remember=$token -X POST -F file=\@${files} http://fisheyehost:8060/rest-service/reviews-v1/$reviewid/addFile ");